Hi Richard! On 12.08.05, Richard Smith wrote:
thanks for the patch! Before commenting on it, I have to admit that I'm not yet fully convinced whether this feature is something really useful
It's probably not. But its kinda neat. I was quite surprised when I figured out how easy adding it was going to be. Few players have this ability.
That's true, I was as well :) So let's add it.
Out of all the stuff I've done to PyTone this was the simplest change so I figured it was a good place to start. An exercise in getting the svn tree and doing the diffs.
These default key bindings look a bit dangerous to me. Couldn't we use a combination like [, ] and ^ (other suggestions would be welcome, too).
Use whatever key bindings you guys wish. I picked these since they made sense to me. Remember that I don't use the curses UI. I have a QT front end. Well most of a QT front end. *grin*
Here, you have to checks whether self.songs is non-empty, otherwise this raises an exception when no song is being played.
Ahh. Ok. I'll add that in.
Fine. Just send me a revised patch. Btw, one thing that was missing was the changes to conf/pytonerc. Could you do this as well, please.
The next patch I'd like to try and submit is the one that groups all of the curses UI files into a UI/curses directory. Allowing for multiple front ends. I think you mentioned previously that you liked that Idea?
Yes, and I still do, although initially this means that there is only going to be a curses directory.
I think it has merit. You have created what I think is a really good player framework. Breaking out the UI stuff into its own allows for others to extend the UI section into things native for their environment.
Definitely. Jörg