On Tue, 17 May 2005, Joerg Lehmann wrote:
On 13.05.05, Dag Wieers wrote:
Another set of comments:
+ The interface feels a bit sluggish and I think that is because if you 'tab' between the 2 windows there is a visible refresh. I've been looking to get rid of it one way or the other but I struggle with ncurses.
Hmm, logging the calls of the doupdate function of the curses library shows only on call after pressing the TAB key.
The refresh is probably worsened by the fact that it clears the area. I have been looking at other ncurses programs and they do not have this behaviour, so somehow it must be able to prevent this.
+ It would be nice if there was a global search facility. Something that is not context sensitive (like the 'j' option in xmms). A popup with all the results as you type.
Yes, I also had this idea. But I wouldn't use a popup, but just show the results in the database window.
Well, having a popup would be nicer in the sense that you do not switch context and since it is find-as-you-type there is no need to stay in the results page when you have found what you were looking for. People are only interested in that one thing they were looking for, not in all the other results that their (imperfect) query returned. That's why the xmms search functionality is brilliant and simple.
+ It would be nice if someone more experienced with 'strace -f -c -p <pid of pytone>' during playback can comment on the immense ammount of futex time spend. I see 11 threads by default for 1 playback, most of the threads spend time in futex. I wonder why there need to be 11 threads ?
Yes, there are many threads running: player(s), audiodevice buffer, database(s), database manager, playlist service, timer service, network service and of course the main UI thread. So at least you have 8 threads running... So PyTone is quite heavily threaded.
My main concern was that each thread is doing plenty of futexes. I have no clue if this is normal at this rate and I also do not know if this is causing my pytone to consume >5% cpu-usage during playback on a 1.2Ghz laptop. Other music players consume considerably less CPU. -- dag wieers, dag@wieers.com, http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power]